Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101110211654.GA3950@genius.kawo2.rwth-aachen.de>
Date: Wed, 10 Nov 2010 22:16:54 +0100
From: Till Maas <opensource@...l.name>
To: john-users@...ts.openwall.com
Subject: jumbo patch Makefile LDFLAGS modifications

Hi,

the jumbo patch from
http://www.openwall.com/john/contrib/john-1.7.6-jumbo-7.diff.gz
contains the following change for Makefile:

-LDFLAGS = -s $(OMPFLAGS)
+LDFLAGS = -s -L/usr/local/lib -L/usr/local/ssl/lib -lcrypto -lm $(OMPFLAGS)

This interfers with packaging john for a distribution like Fedora, where
binaries are compiled with debuging information and stripped by the
build program (rpmbuild) to store the information in a debuginfo
package. Without the jumbo patch, the LDFLAGS can be simply overridden
with a redefinition of LDFLAGS on the make commandline. But with the
jumbo patch LDFLAGS does not contain only optional flags, but mandatory
flags like "-lcrypto -lm". Can the jumbo patch please be modified to use
these mandatory directly in each supported target like e.g. the -lcrypt
flag for the linux-x86-64 target?

An alternate solution would be to move the -s flag to some other
variable, e.g. OPTFLAGS and perform this change in the original john
Makefile:
-LDFLAGS = -s $(OMPFLAGS)
+OPTFLAGS = -s
+LDFLAGS = $(OPTFLAGS) $(OMPFLAGS)

Then redefining OPTFLAGS can be used to get rid of the -s flag.

Regards
Till

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.