Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091207030632.GA20856@openwall.com>
Date: Mon, 7 Dec 2009 06:06:32 +0300
From: Solar Designer <solar@...nwall.com>
To: john-users@...ts.openwall.com
Subject: Re: -nodupes option of JimF patch broken (not works at all)

On Sat, Nov 21, 2009 at 03:09:36PM +0100, Ze0n Kat wrote:
> After compile john the ripper in windows under cygwin, and apply jumbo and
> then JimF patch... tested and works good, but the option of JimF patch
> -nodupes is broken and not works at all.
> 
> If someone can fix it.

I was hoping that someone else (perhaps Jim) would reply, but it seems
that I have to.  "Doesn't work" is generally not a sufficiently
informative problem report.  For a useful bug report, you need to
include:

1. Information on the software involved (including the compiler and OS)
and its versions.  OK, you've almost provided this above. :-)

2. Your exact test case.  This would be the command you run and its
input files (reduced to the required minimum to reproduce the problem -
perhaps just a few lines).  Of course, it may also be a good idea to
avoid including hashes of actual passwords (replace them and state so
explicitly, yet make sure the problem can still be reproduced).

3. Expected behavior (e.g., this-many hashes loaded).

4. Actual behavior (the output from JtR actually received).

At the very least, you needed to mention what you thought the
"non-working" option was supposed to achieve (but did not).

It is quite possible that this will result in someone identifying and
explaining what you might have understood incorrectly (wrong
expectations). ;-)  If there is in fact a bug in the code that you would
demonstrate, it would likely get fixed.

Speaking of this specific option, perhaps it is misnamed, which may very
well be causing confusion...  Maybe it needs to be renamed.  Jim?

Thanks,

Alexander


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.