john-users - Re: faster hash file loading

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:  <loom.20080204T181219-596@post.gmane.org>
Date: Mon, 4 Feb 2008 18:17:29 +0000 (UTC)
From:  helleye <jameskond@...mail.com>
To: john-users@...ts.openwall.com
Subject:  Re: faster hash file loading


thanks for your answer

leave alone for a second the I/O

if we look @ ldr_load_pw_line

if ((current_pw = db->password_hash[pw_hash]))
do {
	if (!memcmp(current_pw->binary, binary,
          format->params.binary_size) &&
        !strcmp(current_pw->source, piece)) {
	 if (!(db->options->flags & DB_WORDS) ||
         !strcmp(current_pw->login, login)) break;
	}
	} while ((current_pw = current_pw->next_hash)); 

if (current_pw) continue; 

looks like this one eliminate dupes
but it might cause square square complexity 
so if i can promise there arent dupes in the file
maybe add a flag -nodupes to the args and then to bypass this check ?
reducing complexity to linear

p.s
saw it does it in a big for (index = 0; index < count; index++) loop
i hope that i can just bypass this check and it wont hurt nothing else

thanks




-- 
To unsubscribe, e-mail john-users-unsubscribe@...ts.openwall.com and reply
to the automated confirmation request that will be sent to you.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.