[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070621235918.GA29251@openwall.com>
Date: Fri, 22 Jun 2007 03:59:18 +0400
From: Solar Designer <solar@...nwall.com>
To: john-users@...ts.openwall.com
Subject: Re: Strange bug when testing --format=ssha
On Fri, Jun 22, 2007 at 02:30:56AM +0400, Solar Designer wrote:
> I'm afraid that this needs to be debugged for real. Determine just what
> and when starts to differ between successful and failed tests.
Well, the thing that differed was the ordering of keys tried by the last
iteration of the previous benchmark (for multiple salts).
NSLDAPS_fmt.c: set_key() assumes that keys are always set up starting
from index 0. Not only may this assumption break with future versions
of JtR, but also the code did not take into consideration that sometimes
crypt_all() and cmp_all() may be called with fewer than the maximum
number of keys to test. In that case, some state would be left from the
previous set of keys tried.
Please try the attached patch. It should fix the immediate issue that
caused those test failures (it does for me).
Thanks,
--
Alexander Peslyak <solar at openwall.com>
GPG key ID: 5B341F15 fp: B3FB 63F4 D7A3 BCCC 6F6E FC55 A2FC 027C 5B34 1F15
http://www.openwall.com - bringing security into open computing environments
View attachment "john-1.7.2-all-7-ssha-fix.diff" of type "text/plain" (800 bytes)
--
To unsubscribe, e-mail john-users-unsubscribe@...ts.openwall.com and reply
to the automated confirmation request that will be sent to you.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
