Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4f445b980703121918x7e61d04eg45df88cbb20b768a@mail.gmail.com>
Date: Tue, 13 Mar 2007 03:18:49 +0100
From: "Alain Espinosa" <alainesp@...il.com>
To: john-users@...ts.openwall.com
Subject: Re: LM an NTLM combination

On 3/13/07, Solar Designer <solar@...nwall.com> wrote:
> > But forget about cmp_all. ...
>
> This was tricky, but I think I figured it out - in cmp_one(), you're
> modifying global variables.  However, cmp_one() may be called more than
> once per hash computation as there may be multiple loaded hashes in a
> given hash bucket.  Please see the second pair of nested loops in
> cracker.c: crk_password_loop().

Hmm, intersting.This means that lines 344,345 dont fix the bug, simply
decrease the probability of show it.

> In -5, you've declared the proper local variables in cmp_one(), thereby
> solving the problem.
>
> Now that you know that cmp_one() may be called more than once per hash
> computation when large numbers of hashes are loaded, you should be able
> to optimize it further for such cases.

I dont think this optimization aport a significant speedup to the
patch, but i give a try.
-- 

alain

-- 
To unsubscribe, e-mail john-users-unsubscribe@...ts.openwall.com and reply
to the automated confirmation request that will be sent to you.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.