|
Message-ID: <75ff4aa88ddeb5c6f10a0b80e6cd57d4@smtp.hushmail.com> Date: Tue, 22 Sep 2015 01:57:04 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Agnieszka's GSoC formats On 22/09/15 01:14, Agnieszka Bielec wrote: > 2015-09-13 21:04 GMT+02:00 Agnieszka Bielec <bielecagnieszka8@...il.com>: >> I did PR but it's not ideal. >> additionally Lyra2-opencl using new computations of gws and lws >> doesn't work on 960m > > repaired, wasn't working also on super, but on test on github > lyra2-opencl fails, can I got an access to this opencl-device? That build-bot is using the CPU device of an fglrx driver. Super's device 3 should be the same, did you try that? I see the bots have some weird failures in your branch: https://circleci.com/gh/magnumripper/JohnTheRipper/1041 https://travis-ci.org/magnumripper/JohnTheRipper/jobs/81490986 https://travis-ci.org/magnumripper/JohnTheRipper/jobs/81490987 There are totally unrelated formats (eg. non-opencl pwsafe) that fail, and they only fail in your branch... Either you have some serious buffer overruns or you changed something in core, breaking things. I see no core changes so my bet is memory overwrite. Did you try building with ASan? Just "./configure --enable-asan" and then re-build from scratch and run a full --test=0. That usually catches such problems. The bots also spell out some problems for you: opencl_yescrypt_fmt_plug.c:546:9: warning: comparison of constant 2251799813685247 with expression of type 'uint32_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] if (p > SIZE_MAX / Sbytes) { ~ ^ ~~~~~~~~~~~~~~~~~ 1 warning generated. yescrypt_fmt_plug.c:344:9: warning: comparison of constant 2251799813685247 with expression of type 'uint32_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] if (p > SIZE_MAX / Sbytes) { ~ ^ ~~~~~~~~~~~~~~~~~ 1 warning generated. In file included from yescrypt-best_plug.c:2: ./yescrypt-simd.c:1093:9: warning: comparison of constant 2251799813685247 with expression of type 'uint32_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] if (p > SIZE_MAX / Sbytes) { ~ ^ ~~~~~~~~~~~~~~~~~ 1 warning generated. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.