[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150917203058.GA19053@openwall.com>
Date: Thu, 17 Sep 2015 23:30:58 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: "struct db_password" allocation
On Thu, Sep 17, 2015 at 11:26:18PM +0300, Solar Designer wrote:
> I just found that someone added a field called "uid" to "struct
> db_password"
BTW, this looks wasteful even with the memory allocation corrected.
The only use is:
log_guess(crk_db->options->flags & DB_LOGIN ? replogin : "?",
crk_db->options->flags & DB_LOGIN ? repuid : "",
Maybe we should drop this field, or maybe we should merge its value into
the login string at loading instead of maintaining a separate pointer.
Even if we don't want to fully merge them, we can do smarter - e.g.,
treat login as a "double string" - assume that there's a second string
after the first NUL unless the first string was empty. Or something.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
