[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150903195219.GB15254@openwall.com>
Date: Thu, 3 Sep 2015 22:52:19 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: OpenCL static/inline (was: Re: PHC: Argon2 on GPU)
On Wed, Sep 02, 2015 at 08:06:18PM +0200, magnum wrote:
> Most/all drivers I know of will always inline, no matter what keyword
> you write (or don't write). Many drivers will quitely do this regardless
> of static and/or inline keywords. But more importantly, some drivers
> will not accept 'static' (neither with nor without 'inline') and others
> will demand either 'static' or 'inline' (but the result is still inline).
>
> So the bottom line afaik is we should declare all and any functions in
> kernels as 'inline' (and not 'static'), for portability. Your recent
> patch to cryptmd5 kernel used 'static inline' and I had to change them
> to just 'inline' in order to get them working on [iirc] some semi-old
> Intel driver.
Oh, OK. Let's standardize on just "inline" for now.
It is not true that all drivers will always inline, though. Most of the
time yes, but not always. I've already posted a counter-example in
here, for some functions in Agnieszka's Argon2 kernels on NVIDIA.
> On another note, those BITALIGN definitions of yours now live in
> opencl_misc.h in case we'll eventually need them somewhere else.
Yes, thanks!
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
