[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABtNtWFX1QwtSsNG4SO+SapKGFjVPhnv5+BFde9oKqkwxtx01Q@mail.gmail.com>
Date: Wed, 19 Aug 2015 08:37:27 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: FMT_OMP_BAD
Hi Alexander,
On Wed, Aug 19, 2015 at 8:34 AM, Solar Designer <solar@...nwall.com> wrote:
> Kai,
>
> On Tue, Aug 18, 2015 at 06:09:23PM +0800, Kai Zhao wrote:
>> There are 4 formats to be confirmed:
>>
>> ripemd-128 and ripemd-160 are in the same file [ripemd_fmt_plug.c],
>> so should we add FAST_FORMATS_OMP check in the
>> ripemd_fmt_plug.c ? We should add the check for ripemd-128, but
>> it will work for ripemd-160 too.
>>
>> Same file: ripemd_fmt_plug.c
>>
>> Ratio: 3.21824 real, 0.32110 virtual ripemd-128, RIPEMD 128:Raw
>> Ratio: 4.02062 real, 0.40184 virtual ripemd-160, RIPEMD 160:Raw
>>
>> Same file: haval_fmt_plug.c
>>
>> Ratio: 3.91475 real, 0.39122 virtual HAVAL-256-3:Raw
>> Ratio: 4.38736 real, 0.43815 virtual HAVAL-128-4:Raw
>
> I think we should treat these the same, as if all 4 were below 4.0 - and
> it looks like you already did in your pull request.
>
> Also, I noticed that all of them lack proper test vectors - some have
> just one correct password, some even test empty string only. Please get
> this corrected (you may create a GitHub issue to track this).
>
Is the previous issue ok ?
https://github.com/magnumripper/JohnTheRipper/issues/1637
And I am trying to add more test vectors for those formats whose
the number of test vectors is small than 2.
Thanks,
Kai
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
