[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150817161310.GA787@openwall.com>
Date: Mon, 17 Aug 2015 19:13:10 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: FMT_OMP_BAD
On Mon, Aug 17, 2015 at 11:10:02AM -0500, JimF wrote:
> If that is the logic wanted for 'fast formats omp', then simply make that
> code a header, that is included last (or right before memdbg.h). Within
> that header you would have things like:
>
> #if !FAST_FORMATS_OMP
> #undef _OPENMP
> #undef FMT_OMP
> #define FMT_OMP 0
> #undef FMT_BAD_OMP
> #define FMT_OMP_BAD 0
> #endif
>
> Then simply include that header file in formats where you want that
> logic. Also, it may be that this header should be included FIRST, since
> the _OPENMP logic being set can make changes in certain headers.
Good idea!
> It if ends up being the first thing, then the header may only need to
> contain:
>
> #if !FAST_FORMATS_OMP
> #undef _OPENMP
> #endif
In this case, it might not be worth having a separate header file.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
