[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150814135711.GA26939@openwall.com>
Date: Fri, 14 Aug 2015 16:57:11 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: auditing our use of FMT_* flags (was: more robustness)
On Fri, Aug 14, 2015 at 09:52:00PM +0800, Kai Zhao wrote:
> Thanks for your advice. How about this ?
>
> static struct fmt_tests tests[] = {
> +/*
> + * The following two test vectors: "USER" and "service" are case-insensitive
> + */
> {"$V$9AYXUd5LfDy-aj48Vj54P-----", "USER"},
> {"$V$p1UQjRZKulr-Z25g5lJ-------", "service"},
> +/*
> + * The following one test vector: "President#44" is case-sensitive
> + */
> {"$V$S44zI913bBx-UJrcFSC------D", "President#44"},
> {NULL}
> +/*
> + * This format supports both case-sensitive and case-insensitive passwords,
> + * so this format should set FMT_CASE
> + */
> };
This looks good to me. Even better would be to move the third comment
to where FMT_CASE is actually set. Thanks!
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
