john-dev - Re: PHC: Argon2 on CPU

Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKGDhHVUH9rCHaUNVPDckLr0XgyMz_1M8vouyztwD=ky-fkMjA@mail.gmail.com>
Date: Wed, 12 Aug 2015 13:51:08 +0200
From: Agnieszka Bielec <bielecagnieszka8@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: PHC: Argon2 on CPU

2015-08-06 16:02 GMT+02:00 Solar Designer <solar@...nwall.com>:
> On Sun, Aug 02, 2015 at 10:46:00PM +0200, Agnieszka Bielec wrote:
>> REF
>> none@...e ~/Desktop/rr/run $ ./john --test --format=argon2i
>> Will run 8 OpenMP threads
>> Benchmarking: argon2i [AVX]... (8xOMP)
>> memory per hash : 100.00 kB
>> using different password for benchmarking
>> DONE
>> Speed for cost 1 (t) of 3, cost 2 (m) of 100
>> Raw:    9216 c/s real, 1160 c/s virtual
>>
>> none@...e ~/Desktop/rr/run $ ./john --test --format=argon2d
>> Will run 8 OpenMP threads
>> Benchmarking: argon2d [AVX]... (8xOMP)
>> memory per hash : 100.00 kB
>> using different password for benchmarking
>> DONE
>> Speed for cost 1 (t) of 3, cost 2 (m) of 100
>> Raw:    10624 c/s real, 1336 c/s virtual
>>
>> OPT
>>
>> none@...e ~/Desktop/rr/run $ ./john --test --format=argon2i
>> Will run 8 OpenMP threads
>> Benchmarking: argon2i [AVX]... (8xOMP)
>> memory per hash : 100.00 kB
>> using different password for benchmarking
>> DONE
>> Speed for cost 1 (t) of 3, cost 2 (m) of 100
>> Raw:    24064 c/s real, 3019 c/s virtual
>>
>> none@...e ~/Desktop/rr/run $ ./john --test --format=argon2d
>> Will run 8 OpenMP threads
>> Benchmarking: argon2d [AVX]... (8xOMP)
>> memory per hash : 100.00 kB
>> using different password for benchmarking
>> DONE
>> Speed for cost 1 (t) of 3, cost 2 (m) of 100
>> Raw:    27008 c/s real, 3418 c/s virtual
>
> Nice speeds for presumably SIMD-less code

previously SIMD was 3x faster and this was suspicious for me

> but please note that both of
> your benchmarks above (REF and OPT) say AVX.  Are they lying?

I changed only

#ifdef __SSE2__
    ARGON2i_SSE
#else
    ARGON2i
#endif
        (out, outlen, in, inlen, salt, saltlen, t_cost, m_cost, lanes,
memory->aligned);

to

#ifdef __SSE2__
    ARGON2i
#else
    ARGON2i
#endif
        (out, outlen, in, inlen, salt, saltlen, t_cost, m_cost, lanes,
memory->aligned);

and some indef's / undefs in another files

>
>> but I was testing these no-sse versions by modyfiyng my code, don't
>> know if I can just turn-off simd (?), so I can't be sure of these
>> results although I know that structure of REF is different than
>> OPT-SSE one(maybe more) function was called a different number of time
>
> I'm sorry, but I find your wording above confusing.  So let me try to
> ask a clarifying question:
>
> Are you reviewing the generated assembly code?  It's trivial to see if
> the code is using SIMD or not.
>
> And while we're at it:
>
> How are you obtaining the assembly code for review?  Do you replace
> gcc's "-c" option with "-S"?  Or do you use "objdump -d" on the .o file?

I revieved using objdump and I use only objdump
files argon2d_sse_plug.o argon2i_sse_plug.o blake2b_plug.o are empty
argon2d_plug.o argon2i_plug.o blake2b-ref_plug.o doesn't contain simd code
I hope I checked all necessary files
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.