john-dev - Re: auditing our use of FMT_* flags (was: more robustness)

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABtNtWG+JDEgwMyZTvQy_f3sS60HVUBBp65TDV3a41H_hhu5cQ@mail.gmail.com>
Date: Mon, 27 Jul 2015 16:27:24 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: auditing our use of FMT_* flags (was: more robustness)

formats.h: 51~60

/*
 * This flag must be set for formats that do UCS-2, UTF-16 or some other
wide
 * encoding internally (eg. most Microsoft formats). The most common problem
 * with formats not fully Unicode-aware is when a format like this is
hard-coded
 * to convert from ISO-8859-1 (ie. by just inserting 0x00, effectively just
 * casting every char to a short). Such formats MUST set FMT_UNICODE and
MUST
 * NOT set FMT_UTF8, or users will get false negatives when using UTF-8 or
 * codepages.
 */
#define FMT_UNICODE                     0x00000004

"Such formats MUST set FMT_UNICODE and MUST NOT set FMT_UTF8"
Here "Such formats" points to "The most common problem with formats..." ?

Can anyone explain this ? Is there  any example ?

I have found that there are only two formats which set FMT_UNICODE and
NOT set FMT_UTF8. They are:

opencl_mscash_fmt_plug.c,  opencl_nt_fmt_plug.c

There are 27 formats which both set FMT_UNICODE and SET FMT_UTF8.

dynamic_29, dynamic_33, dynamic_1032, dynamic_1400, EFS, EPiServer,
mscash, mscash2, MSCHAPv2, mschapv2-naive, krb5pa-md5, mssql,
mssql05, mssql12, netlmv2, netntlmv2, netntlm, netntlm-naive, NT, Office,
oldoffice, oracle, rar, Raw-MD5u, 7z, SybaseASE, NT-old

Thanks,

Kai

Content of type "text/html" skipped

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.