Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list] 
Message-ID: <CABtNtWFiTpc_XWf=h6anVBBFK8xaGgdgGPyNPSOfzgWc9uyi9w@mail.gmail.com>
Date: Sun, 26 Jul 2015 20:31:38 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style

>>         if (x == y) {
>>                 ..
>>         } else if (x > y) {
>>                 ...
>>         } else {
>>                 ....
>>         }
>
> IMHO we should allow this too
>         if (x == y) {
>                 ..
>         }
>         else if (x > y) {
>                 ...
>         }
>         else {
>         ....
>        }

There is also another style in john.

static void john_run(void)
{
        struct stat trigger_stat;
        int trigger_reset = 0;
        if (options.flags & FLG_TEST_CHK)
                exit_status = benchmark_all() ? 1 : 0;
        else
        if (options.flags & FLG_MAKECHR_CHK)
                do_makechars(&database, options.charset);
        else
        if (options.flags & FLG_CRACKING_CHK) {
                ...
        }
}

Should we allow this style too ?

Thanks,

Kai

Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.