[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55942AF6.90602@mailbox.org>
Date: Wed, 1 Jul 2015 20:01:26 +0200
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Re: Makefile.legacy
On 07/01/2015 06:17 PM, Solar Designer wrote:
> Oh, I just found this commit:
>
> commit cd510d4bc5c42d7cd1f99064dd7456888b6a7507
> Author: Frank Dittrich <frank.dittrich@...lbox.org>
> Date: Wed Jun 11 23:08:10 2014 +0200
>
> Makefile.legacy: avoid make warnings for generic builds
>
> Compiling: DES benchmark (code version #1)
> make[1]: Entering directory `/home/fd/git/JtR/src'
> make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
>
> Instead of adding '+' to the "parent" make rule I passed -j1 to ./best.sh
>
> And it looks bad to me. Please revert it.
After Makefile had been renamed (first to Makefile.orig, then to
Makefile.legacy) when autoconf was introduced, that caused various
problems, so there were several questionable changes...
When I change Makefile.legacy like this:
-MAKE_BEST_JTR = $(MAKE) -j1 -f Makefile.legacy
-MAKE_ORIG = $(MAKE) -f Makefile.legacy -j$(J)
+MAKE_BEST_JTR = $(MAKE) -f Makefile.legacy
+MAKE_ORIG = +$(MAKE) -f Makefile.legacy
I get:
$ make -s -j 2 -f Makefile.legacy generic
Compiling: DES benchmark (code version #1)
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent
make rule.
Benchmarking: descrypt, traditional crypt(3) [DES 48/64 4K]... 408192
c/s real, 408192 c/s virtual
Compiling: DES benchmark (code version #2)
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent
make rule.
Benchmarking: descrypt, traditional crypt(3) [DES 48/64 128K]... 360960
c/s real, 360960 c/s virtual
Compiling: DES benchmark (code version #3)
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent
make rule.
Benchmarking: descrypt, traditional crypt(3) [DES 48/64 4K]... 416384
c/s real, 416384 c/s virtual
If I keep the -j1 for MAKE_BEST_JTR, I get
$ make -s -j 2 -f Makefile.legacy generic
Compiling: DES benchmark (code version #1)
make[1]: warning: -jN forced in submake: disabling jobserver mode.
Benchmarking: descrypt, traditional crypt(3) [DES 48/64 4K]... 369024
c/s real, 369024 c/s virtual
Compiling: DES benchmark (code version #2)
make[1]: warning: -jN forced in submake: disabling jobserver mode.
Benchmarking: descrypt, traditional crypt(3) [DES 48/64 128K]... 369920
c/s real, 369920 c/s virtual
Any ideas?
But for MAKE_ORIG, the issues have gone (I did not yet push that change).
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
