Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150622033913.GA16542@openwall.com>
Date: Mon, 22 Jun 2015 06:39:13 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style

Kai,

On Sun, Jun 21, 2015 at 12:42:47PM +0800, Kai Zhao wrote:
> As to function declaration, use a tab or 4 spaces?
> 
> use a tab
> ------------
> 
> loader.c  line: 44
> 
> static void read_file(struct db_main *db, char *name, int flags,
>         void (*process_line)(struct db_main *db, char *line))
> 
> 
> use 4 spaces
> ------------------
> 
> formats.c line: 50
> 
> static char *fmt_self_test_body(struct fmt_main *format,
>     void *binary_copy, void *salt_copy)

My current preference is using 4 spaces for continuation lines like
this.  And yes, we should make this consistent.

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.