[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHNEV5RMaa7hkHtuCZ9PqdL4pgHSZEkv6VQEdhSb1S8VORQL1A@mail.gmail.com>
Date: Sun, 31 May 2015 17:37:12 -0400
From: Mathieu Laprise <mathlaprise@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: problem with signal handling in core john (was: [core
john] [Johnny] Windows event loop)
On Sun, May 31, 2015 at 3:16 AM, Solar Designer <solar@...nwall.com> wrote:
> While at it, I also changed all __CYGWIN32__ to __CYGWIN__ elsewhere in
> the tree and removed bits that were specific to ancient Cygwin versions
> (which would define __CYGWIN32__ but not __CYGWIN__).
>
> I didn't add #include <wincon.h>, which was in your patch. This
> appeared wrong to me, because it was not needed so far and we're not
> starting to use any new symbol with this patch. Additionally, the MSDN
> page on SetConsoleCtrlHandler() says:
>
> "Header Wincon.h (include Windows.h)"
>
> which might mean that we should be including windows.h only, just like
> we do now.
>
> Is this OK?
>
I guess it is OK since the new core john is exiting great with Johnny on my
Windows machine.
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
