Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <147A832E-2C04-4327-8773-D5923C1B9C1F@shinnok.com>
Date: Thu, 14 May 2015 15:23:34 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: Re: problem with signal handling in core john (was: [core john] [Johnny] Windows event loop)


> On May 13, 2015, at 4:11 PM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
> 
> On Wed, May 13, 2015 at 03:52:20PM +0300, Shinnok wrote:
>> 
>>> On May 13, 2015, at 3:27 PM, Solar Designer <solar@...nwall.com> wrote:
>>> 
>>> Aleksey, Shinnok -
>>> 
>>> On Wed, May 13, 2015 at 02:31:18PM +0300, Aleksey Cherepanov wrote:
>>>> The possible problems:
>>>> 
>>>> - SetConsoleCtrlHandler(NULL, FALSE); may be needed to enable ctrl-c
>>>> correctly, I guess john core wants to handle ctrl-c,
>>> 
>>> I haven't been following the discussion closely, I'm not into Windows
>>> programming, and IIRC it's been something between 15 and 20 years since
>>> I put the SetConsoleCtrlHandler() calls currently in signals.c in there.
>>> So I don't really know whether/which change might be needed.  However,
>>> last time I checked, which wasn't that long ago, Ctrl-C still worked
>>> fine to correctly terminate "john" on Windows.  Does it no longer work
>>> in console on some combination of Windows and Cygwin versions?  Or is
>>> the problem specific to just usage from Johnny?
>> 
>> The patch maintains event processing(including CTRL_C) under the console(CMD) while also allowing for Johnny to properly terminate JtR instances via the same CTRL_C_EVENT.
> 
> As I understand from previous mails, john work under cmd.exe well, but
> when it is called from a program that disabled handling of ctrl-c for
> itself (like Johnny, but not limited to it) john inherits that
> disabled handling and does not enable it. Shinnok - am I right?
> 

That is correct.

Shinnok


Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.