[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <32F0ED6D-C110-4379-97BC-7B8D7530F1E9@shinnok.com>
Date: Fri, 8 May 2015 14:11:50 +0300
From: Shinnok <admin@...nnok.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: Re: [Johnny] TODO and comments in code
Ok, I'll add both the Windows work(let's keep to only what can be done now) and the comments cleanup one as tasks for v1.4 and assign to you.
For the latter the recommended approach is to create a branch and start going over the comments one by one. Everything that is unclear or can't be fixed with a one two liner should be brought here for discussion and possibly conversion to a separate task. Use a single fix per commit so that it's easier for me to later review your PR.
Thanks,
Shinnok
> On 08 May 2015, at 13:14, Mathieu Laprise <mathlaprise@...il.com> wrote:
>
> Shinnok, you can take your time. Since yesterday, I'm working really hard on Windows support (see thread Windows évent loop Johnny John core ).
>
>> On Fri, May 8, 2015 at 2:04 AM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
>> On Fri, May 08, 2015 at 08:27:23AM +0300, Shinnok wrote:
>> >
>> > > On May 8, 2015, at 1:13 AM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
>> > >
>> > > On Thu, May 07, 2015 at 07:40:35PM +0300, Shinnok wrote:
>> > >>
>> > >>> On May 6, 2015, at 11:55 PM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
>> > >>>
>> > >>> Shinnok,
>> > >>>
>> > >>> I've used default branch from your repo:
>> > >>> $ git clone https://github.com/shinnok/johnny
>> > >>>
>> > >>> I think I'll bring everything to the list to be discussed.
>> > >>
>> > >> Please don't do that. Unless you have the time to handle it properly(like I mentioned in the prev. e-mails), I suggest we let Mathieu exercise on it. I have enough to collect from the list and organize already. If you dump everything from there into here that's going to make things worse for me.
>> > >
>> > > I've looked over some todos. I still think that they are not very
>> > > important. Some todos may be solved by your picture of wanted
>> > > structure, so you may want to glance at them.
>> >
>> > Do you have a commit? If not I'd urge Mathieu to pick this up right away.
>>
>> I am confused: what is the commit for? I did not remove any todos yet.
>>
>> I revisited the todo in question. I already posted it.
>>
>> QAbstractTableModel *m_hashesTable;
>> // TODO: Probably the right place for this field is in table model.
>> // But this needs to have abstract interface that supports
>> // connection with files. Someone could suppose to drop
>> // generated tables out but if we want to have tables
>> // joining, editing and so on tables that is not connected
>> // with files yet are necessary.
>> // However now this is here.
>>
>> Currently there is the abtract model field. MainWindow::readPasswdFile
>> reads the fileName file using FileTableModel and replaces current
>> model in the field with the new one.
>>
>> QAbstractTableModel is used because other table model (TableModel) was
>> used by you for testing of table view. I had an idea to drop the
>> QAbstractTableModel but I did not move in that direction.
>>
>> The abstract interface may or may not be useful to support other types
>> of loading. Since then I learned that john can load simultaneous files
>> at the same time
>> $ john *.pw
>> and john processes all of them. So having table model with multiple
>> files may be useful. Though I don't know how it should be implemented.
>> Also I don't know what other things may relate to the table model. I
>> think you know that better.
>>
>> BTW the name of file is stored in the MainWindow object:
>> // After new model remembered we remember its file name.
>> m_hashesFileName = fileName;
>>
>> Thanks!
>>
>> --
>> Regards,
>> Aleksey Cherepanov
>
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
