john-dev - Re: [Johnny] TODO and comments in code

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508060427.GA1755@openwall.com>
Date: Fri, 8 May 2015 09:04:27 +0300
From: Aleksey Cherepanov <lyosha@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: [Johnny] TODO and comments in code

On Fri, May 08, 2015 at 08:27:23AM +0300, Shinnok wrote:
> 
> > On May 8, 2015, at 1:13 AM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
> > 
> > On Thu, May 07, 2015 at 07:40:35PM +0300, Shinnok wrote:
> >> 
> >>> On May 6, 2015, at 11:55 PM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
> >>> 
> >>> Shinnok,
> >>> 
> >>> I've used default branch from your repo:
> >>> $ git clone https://github.com/shinnok/johnny
> >>> 
> >>> I think I'll bring everything to the list to be discussed.
> >> 
> >> Please don't do that. Unless you have the time to handle it properly(like I mentioned in the prev. e-mails), I suggest we let Mathieu exercise on it. I have enough to collect from the list and organize already. If you dump everything from there into here that's going to make things worse for me.
> > 
> > I've looked over some todos. I still think that they are not very
> > important. Some todos may be solved by your picture of wanted
> > structure, so you may want to glance at them.
> 
> Do you have a commit? If not I'd urge Mathieu to pick this up right away.

I am confused: what is the commit for? I did not remove any todos yet.

I revisited the todo in question. I already posted it.

    QAbstractTableModel *m_hashesTable;
    // TODO: Probably the right place for this field is in table model.
    //       But this needs to have abstract interface that supports
    //       connection with files. Someone could suppose to drop
    //       generated tables out but if we want to have tables
    //       joining, editing and so on tables that is not connected
    //       with files yet are necessary.
    //       However now this is here.

Currently there is the abtract model field. MainWindow::readPasswdFile
reads the fileName file using FileTableModel and replaces current
model in the field with the new one.

QAbstractTableModel is used because other table model (TableModel) was
used by you for testing of table view. I had an idea to drop the
QAbstractTableModel but I did not move in that direction.

The abstract interface may or may not be useful to support other types
of loading. Since then I learned that john can load simultaneous files
at the same time
$ john *.pw
and john processes all of them. So having table model with multiple
files may be useful. Though I don't know how it should be implemented.
Also I don't know what other things may relate to the table model. I
think you know that better.

BTW the name of file is stored in the MainWindow object:
        // After new model remembered we remember its file name.
        m_hashesFileName = fileName;

Thanks!

-- 
Regards,
Aleksey Cherepanov

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.