|
Message-ID: <554B7DA1.6080907@mailbox.org> Date: Thu, 07 May 2015 16:58:41 +0200 From: Frank Dittrich <frank.dittrich@...lbox.org> To: john-dev@...ts.openwall.com Subject: Re: Session names somename.[0-9]+ shouldn't be allowed On 05/07/2015 04:46 PM, Solar Designer wrote: > On Wed, May 06, 2015 at 11:57:11PM +0200, Frank Dittrich wrote: >> Even worse, this breaks the JtR test suite. >> The test suite is located in a test subdir at the same level as run and src. > [...] >> In this case, jtrts.pl uses --session=./tst to make sure the .rec and >> .log files remain in the test subdir, even if the john binary is located >> in ../run/. >> >> So, dots in the path name should be allowed. jtrts.pl has meanwhile been changed. It uses --session=tst instead of --session=./tst now. But may be john used different default paths for .rec/.log, depending on JOHN_SYSTEMWIDE_EXEC. That might have been the reason to use --session=./tst. > Ouch. I'd rather not. As I just wrote in another message, this was > never supposed to work that way. The option specifies session names, > not pathnames. > > However, I am open to discussing and possibly changing this, if there > are good reasons to allow for pathnames there. It might be good to allow applications like Johnny or the test suite to have full control over the exact location of the .rec and .log files. This makes cleanup easier and reduces the risk of interfering with sessions created by the user. And if the default location of .rec files can vary, depending on the john version, I'd need some way to query that default location for bash completion of --restore=[tab]. Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.