[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150506143114.GC2780@openwall.com>
Date: Wed, 6 May 2015 17:31:15 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Undefined behavior in bench.c (null pointer passed as argument 1 to memcpy)
On Wed, May 06, 2015 at 02:18:17AM +0200, Frank Dittrich wrote:
> bench.c line 138 is:
>
> memcpy(two_salts[index], salt, format->params.salt_size);
>
> and, apparently, two_salts[index] is NULL here (and for other saltless
> formats).
>
> Since this is core code, magnum would obviously prefer a core change
> over a jumbo specific change.
Fixed in core:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/bench.c.diff?r1=1.22;r2=1.23
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
