[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9be083d0355142a6357d02efb21cdd94@smtp.hushmail.com>
Date: Tue, 05 May 2015 00:06:36 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: get_key() returning 0 causes self tests to crash
On 2015-05-04 23:23, Solar Designer wrote:
> On Mon, May 04, 2015 at 11:10:55PM +0300, Aleksey Cherepanov wrote:
>> When get_key() method does
>> return 0;
>> self tests crash ungracefully (segfault). I'd expect a message^
>>
>> FAILED (get_key() returned NULL)
>>
>> like for binary() returning 0.
>
> This may be fine for debugging, but FWIW all those NULL checks are
> jumbo-specific. In the core tree, there's no check for binary()
> returning NULL either.
I just added such test although not very important. Tests that check for
problems that would otherwise go un-noticed are more important, like a
format not supporting its claimed max length at all.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
