[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CB05257A-2DAD-4DE4-B5BA-1492CD3C6F00@shinnok.com>
Date: Mon, 4 May 2015 17:27:35 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: Re: [Johnny] Task 1.4.2 fork and OpenMP
>
> If yes, Mathieu, I think you need to change your override of JohnProcess::terminate() to not send SIGTERM twice in the OS_FORK case(looking over your Github branch). Also you should use Q_OS_ defines to probe for OS'es instead of GCC builtins(or otherwise)?
>
> 1) Okay, for define, I'll use Q_OS_UNIX instead of gcc. 2) Does JtR --fork works on OS X too since it's based on unix?
Yes, I tested that and it works fine on OS X.
> 3) Do you mean
> void JohnProcess::terminate()
> {
> #if OS_FORK
> if(processId() != 0)
> {
> ::kill(-processId(),SIGTERM);
> }
> + #else
> QProcess::terminate();
> #endif
> }
This version, yes.
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
