Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <553420A6.4090801@openwall.com>
Date: Mon, 20 Apr 2015 00:39:50 +0300
From: Alexander Cherepanov <ch3root@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Add __attribute__ ((__noreturn__)) to error() and
 pexit() in misc.h

On 2015-04-17 18:44, Frank Dittrich wrote:
> please consider adding __attribute__ ((__noreturn__)) to error() and
> pexit() in misc.h.

IMHO there is too much preprocessor directives scattered over the code. 
Perhaps in this case noreturn macros could be used in front of the 
mentioned functions? Its definition could be as follows:

#if __STDC_VERSION__ >= 201112L
     #include <stdnoreturn.h>
#elif __GNUC__
     #define noreturn __attribute__ ((noreturn))
#elif _MSC_VER
     #define noreturn __declspec(noreturn)
#else
     #define noreturn
#endif

-- 
Alexander Cherepanov

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.