[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5526B7F6.8010601@mailbox.org>
Date: Thu, 09 Apr 2015 19:33:42 +0200
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style
On 04/09/2015 05:58 PM, Solar Designer wrote:
> On Thu, Apr 09, 2015 at 08:58:42PM +0800, Kai Zhao wrote:
>> Even though
>> Kernel style states that "Never break user-visible strings such as printk
>> messages even it exceeds column 80" , the checkpatch.pl can't find this
>> problem, since the situation maybe complex. I think it would be better to
>> manually review these strings.
>
> FWIW, while I understand the rationale behind this rule, I dislike it.
Since the Linux kernel's code base is much larger than our, may be that
rule isn't so important for us.
But some output could easily be rewritten without exceeding the max.
line size of 80:
fprintf(stderr,
"Hardware resources exhausted\n");
instead of
fprintf(stderr, "Hardware resources "
"exhausted\n");
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
