[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150409160354.GC2097@openwall.com>
Date: Thu, 9 Apr 2015 19:03:54 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style
On Thu, Apr 09, 2015 at 10:07:14PM +0800, Kai Zhao wrote:
> Attachment is the result of checking john-1.8.0 with checkpatch.pl. The
> total
> number of errors and warnings is much smaller than the john jumbo,
> especially the errors of john core are not many. I think the general coding
> style of john core is standard.
Is this the entire output of the script? If so, I am surprised it
didn't find more instances of some of the same (non-)issues it spotted.
There are more of some of these in there.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
