[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55268F12.6010105@mailbox.org>
Date: Thu, 09 Apr 2015 16:39:14 +0200
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style
On 04/09/2015 04:07 PM, Kai Zhao wrote:
> Attachment is the result of checking john-1.8.0 with checkpatch.pl
> <http://checkpatch.pl>. The total
> number of errors and warnings is much smaller than the john jumbo,
> especially the errors of john core are not many. I think the general coding
> style of john core is standard.
Can you please name plain text attachments *.txt?
This one definitely is a false positive:
ERROR: space prohibited before open square bracket '['
#50: FILE: john_core/src/BF_std.c:50:
+#define INDICES [BF_N]
And why is it that only line 50 triggers this message, but not the
subsequent lines or similar lines in DES_bs_b.c?
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
