john-dev - Re: Coding Style

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABtNtWH_h_dg3S-a6+hhSzkHTYN4Ca1LBC-R-WqA6gw+TkFrEg@mail.gmail.com>
Date: Wed, 8 Apr 2015 16:58:49 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style

Here are the specific differences between our current coding style and
Kernel
style.

1. Don't put multiple statements on a single line

There are some cases in john which does not meet this requirement, such as
below:

src/loader.c : 746

if (current_pw) continue;

2. Never break user-visible strings such as printk messages even it exceeds
column 80, because that breaks the ability to grep for them. This rule is
the
same as Frank's idea.

There are some cases in john which does not meet this requirement, such as
below:

src/common-opencl.c : 1732

fprintf(stderr, "Hardware resources "
          "exhausted\n");

3. Use only C89 "/* ... */" style and don't use C99-style " // ..."

John core meets this requirement but jumbo does not.

As for the three differences, I think we should change our style.

Thanks,

Kai

Content of type "text/html" skipped

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.