[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55215933.5010304@openwall.com>
Date: Sun, 05 Apr 2015 18:48:03 +0300
From: Alexander Cherepanov <ch3root@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style
On 2015-04-05 13:08, magnum wrote:
> On 2015-04-05 06:46, Kai Zhao wrote:
>>> Unfortunately a lot of the code deviate from our coding style.
>>
>> Yes, I have found some functions which put the opening brace of a function
>> body on the same line. Such as below:
>
> What we might want to do is one or a few pure whitespace commits. That
> is, fix issues like the above, tab/space errors, trailing whitespace and
> missing final newlines and make NO other changes in the same commit.
> When shown with eg. "git show -w" or "diff -w" the commit should be empty.
I strongly agree. But with a "pure whitespace" replaced with "pure
style". I don't think we can get empty "diff -w" if we want to move a
brace to another line. Style changes could be split into whitespace-only
and everything else, though.
--
Alexander Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
