[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b434563c3f1c6e22301583b8aa92cfb7@smtp.hushmail.com>
Date: Wed, 25 Mar 2015 22:18:28 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Pomelo format (was: Re: [GSoC] John the Ripper support
for PHC finalists)
On 2015-03-25 21:24, Agnieszka Bielec wrote:
> This is my new repository. I hope it's far better than the previous one
> https://github.com/Lucife-r/JohnTheRipper
Hi, I did a super-quick review of your commit (well I almost didn't look
at the actual code yet, just the diffstat). Some comments before a
possible merge to our main repo:
* You have two files in the base directory (parent of src).
Pomelo_testvectors.txt perhaps should go to the "src/unused" directory,
where we keep some reference stuff that are not used for building. And
pomelo.c - this is a larger, not used variant of src/pomelo.c? It should
probably go to src/unused too, or dropped. The files that are actually
used (eg. src/pomelo.c) could instead have comments added with links
(web urls) to original source.
* This is poorly documented, but you can actually rename src/pomelo.c to
src/pomelo_plug.c and drop *all* changes to Makefile.in! Our "MacGyver
plugin system[tm]" will take care of it. Unlike format plugs that need
some special #ifdef stancas inside, there is nothing special about a
non-format plugin except the name ending in "_plug.c". The accompanying
src/pomelo.h does not need a rename.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
