|
Message-Id: <CD24259D-5A83-49C6-886B-DFD9AC882161@gmail.com> Date: Sat, 21 Mar 2015 08:14:56 +0800 From: Lei Zhang <zhanglei.april@...il.com> To: john-dev@...ts.openwall.com Subject: Re: [GSoC] building JtR for MIC I thought -DFOO means '#define FOO', without a specific value bound to FOO. I was wrong. Sorry, I'll fix this. Lei > On Mar 21, 2015, at 7:32 AM, magnum <john.magnum@...hmail.com> wrote: > > On 2015-03-20 13:51, Lei Zhang wrote: >> There's a bug in jumbo.h, line 209: >> ---------------------------- >> #if !AC_BUILT >> ---------------------------- >> Actually AC_BUILT is defined in command line by -DAC_BUILT, and it won't pass this test. We should use #ifndef instead. > > Did you see this ending up as an actual problem or did you "think" it's > a problem? You make a common mistake unless I fail to get your point. > The syntax -DFOO means "define FOO to 1". > > magnum > >
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.