|
Message-ID: <20150307112355.GA14442@openwall.com> Date: Sat, 7 Mar 2015 14:23:55 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Cc: Spil Oss <spil.oss@...il.com> Subject: Re: Replace deprecated des_ methods with DES_ > On 2015-03-06 12:08, Spil Oss wrote: > > During a recent build of all FreeBSD ports with LibreSSL as a > > replacement of OpenSSL we've discovered that John the Ripper doesn't > > build with LibreSSL. This is due to the use of des_ methods and types > > that have been deprecated with OpenSSL 0.9.7 and will be removed with > > OpenSSL 1.1.0. > > > > Attached patches replace the deprecated des_ methods and calls that > > were available in openssl/des_old.h with the supported DES_ > > counterparts. > > > > Please consider including this in your code. Thank you, Bernard! On Sat, Mar 07, 2015 at 12:51:32AM +0100, magnum wrote: > I had no idea there was any such problem. I will gladly commit your > patches but I'm hoping someone else will agree before I do. Does anyone > see any problem with committing this? I take it we'll still support at > least OpenSSL 0.9.7 so I see no problem. I agree this should be committed, and we should test-build on a few systems with different OpenSSL versions. There were many more instances of the deprecated des_old identifiers in JtR formats contributed over a decade ago, which we've updated years ago - but apparently a few remained. And keychain_fmt_plug.c is a fairly recent addition, so apparently it was written that way recently. Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.