Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20150212114910.DXMGE.357186.imail@eastrmwml207>
Date: Thu, 12 Feb 2015 11:49:10 -0500
From:  <jfoug@....net>
To: john-dev@...ts.openwall.com
Subject: Re: wrong comment in sha512crypt_fmt_plug.c

changed in bleeding jumbo (in git)  https://github.com/magnumripper/JohnTheRipper/commit/9f011b08a966598fad724b6dd1fc9a16b7673b66

---- Aleksey Cherepanov <aleksey.4erepanov@...il.com> wrote: 
> It looks like there is a wrong comment in cryptsha512_fmt_plug.c :
> 
> 		/* For every character in the password add the entire password.  */
> 		for (cnt = 0; cnt < 16 + ((unsigned char*)crypt_out[index])[0]; ++cnt)
> 			SHA512_Update(&alt_ctx, cur_salt->salt, cur_salt->len);
> 
> It is #18 according to
> http://www.akkadia.org/drepper/SHA-crypt.txt
> "
> 18. repeast the following 16+A[0] times, where A[0] represents the first
>     byte in digest A interpreted as an 8-bit unsigned value
> 
>       add the salt to digest DS
> "

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.