Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list] 
Message-ID: <535A5251.9090300@synacktiv.com>
Date: Fri, 25 Apr 2014 14:17:21 +0200
From: Julien Legras <julien.legras@...acktiv.com>
To: john-dev@...ts.openwall.com
Subject: Compilation failure

Hello,

I pull this morning the f6c2ea0e932cf613697f5947b2418e04d9ee9be7 
revision from bleeding-jumbo branch and the compilation fails with the 
following error:

gcc -c -Wall -Wdeclaration-after-statement -O2 -fomit-frame-pointer 
-I/usr/local/include          -DHAVE_CRYPT -DHAVE_DL -march=native 
-funroll-loops wordlist.c -o wordlist.o
wordlist.c: In function ‘do_wordlist_crack’:
wordlist.c:370:57: error: expected expression before ‘;’ token
   regex = prepare_regex(regex, &regex_case, &regex_alpha);
                                                          ^

The regex is already modified in the prepare_regex function so there is 
no need to assign the return value. Please, tell me if I am wrong.

Here is a quick fix (git diff):

diff --git a/src/wordlist.c b/src/wordlist.c
index 7eb6817..277cbf0 100644
--- a/src/wordlist.c
+++ b/src/wordlist.c
@@ -367,7 +367,7 @@ void do_wordlist_crack(struct db_main *db, char 
*name, int rules)
         if (options.activewordlistrules)
                 log_event("- Rules: %.100s", options.activewordlistrules);

-       regex = prepare_regex(regex, &regex_case, &regex_alpha);
+       prepare_regex(regex, &regex_case, &regex_alpha);

         length = db->format->params.plaintext_length;
         if (options.force_maxlength && options.force_maxlength < length)




Julien Legras

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.