[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140403064505.GB29196@openwall.com>
Date: Thu, 3 Apr 2014 10:45:05 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Long time bug found (I hope found), in dyna
Jim -
On Thu, Apr 03, 2014 at 01:18:21AM -0400, jfoug@....net wrote:
> Well, I was able to enhance that salt sort, to keep the wpapsk code, and simply add the same code to do it for salted dyna's. Very easy fix, and again, the problem goes away. This code still needs a little more testing, etc, but I hope to have it checked in soon.
Thanks! Please include a comment near the salt sorting code saying that
this sorting is crucial for your dyna formats.
> One thing that still bothers me is this. The self test code did not catch this problem. Dyna6 has salts of different length. However, the test bench code does not behave like the 'normal' run of JtR, and thus would not catch this type problem. I think we need to look into that.
Right.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
