|
Message-ID: <BLU0-SMTP150A5C109A103C015A97F9BFDB60@phx.gbl> Date: Tue, 7 Jan 2014 10:11:23 +0100 From: Frank Dittrich <frank_dittrich@...mail.com> To: john-dev@...ts.openwall.com Subject: Re: CUDA multi-device support On 01/07/2014 06:44 AM, magnum wrote: > Always review your commits (use git gui and stage a hunk at a time as > opposed to a blind "git add -a ." I see no problem in "git add -a" or even "git commit -a", if you checked with "git diff" (make sure you are in the top level directory) and "git status" what will be part of your commit. If you notice something went wrong, you can still quit while editing your commit message or use "git commit --amend" or "git revert" to correct the problem after you accidentally committed some unfinished work. > and always review things like PRs, Yes, there should just be your own few commits. And if you notice unrelated changes in them, you might want to "git rebase" first. That way, magnum will have less trouble with possible merge conflicts. Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.