|
Message-ID: <e30245b4d7a657e5d7a1b4427c705c9b@smtp.hushmail.com> Date: Thu, 28 Nov 2013 00:46:33 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: new format parameter patch for bleeding-jumbo On 2013-09-01 15:25, magnum wrote: > On 1 Sep, 2013, at 15:14 , Sayantan Datta <std2048@...il.com> wrote: >>> On Sun, Sep 1, 2013 at 5:09 PM, magnum <john.magnum@...hmail.com> wrote: >>> I think we should stop and think for a minute first. Why not just use a global variable instead? All formats initially set this to zero, even your mask-enabled ones - so what good does this in the format struct? >> >> Yes, for now it does nothing. But I will post a patch for bleeding-mask that will do initial processing of mask during format initialization, at least that is the plan. This will help us in future to write a self test for mask mode. Also I think initial processing of mask should be done during format initialization, not before cracking. > > OK. So maybe it should initially tell the maximum figure that may be used, and after init/reset it will tell the actual figure for this run? That would probably help fixing https://github.com/magnumripper/JohnTheRipper/issues/328 too. > > I'll apply it now. Sayantan, As you apparently abandoned the mask mode branch I have now reverted the above change (in hindsight I was an idiot agreeing to commit it) and I won't merge any more changes into the bleeding-mask branch. I see no point in spending my resources on that while you do not. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.