john-dev - wordlist.c artefacts

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a68eb787e9896745d2d8e426d6e33255@smtp.hushmail.com>
Date: Thu, 26 Sep 2013 00:35:52 +0200
From: magnum <john.magnum@...hmail.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: wordlist.c artefacts

Solar,

This hunk came with 1.7.9.6-c6, made it into bleeding-jumbo's wordlist.c 
when I merged core fork/node and still remain there:

@@ -378,6 +377,9 @@ void do_wordlist_crack(struct db_main *db, char 
*name, int rules)
                    trash the buffer. It's also disabled by --save-mem=N */
                 ourshare = (file_len / options.node_count) *
                         (options.node_max - options.node_min + 1);
+               if (options.node_count >= 1000000000)
+                       ourshare = 0;
+               if (options.node_count != 1000000000)
                 if (!(options.flags & FLG_EXTERNAL_CHK) && 
!mem_saving_level)
                 if ((options.node_count > 1 &&
                      file_len > options.node_count * (length * 100) &&


What are those 1G tests for? Some kind of debugging? I should remove 
them, right?

magnum

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.