Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3d1ae5ddd3f8debd90f067b5f2fdbb25@smtp.hushmail.com>
Date: Sun, 1 Sep 2013 13:39:11 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: new format parameter patch for bleeding-jumbo

On 1 Sep, 2013, at 7:30 , Sayantan Datta <std2048@...il.com> wrote:
> This patch does not add any functionality to bleeding-jumbo, but it would help us to keep bleeding-mask as close to bleeding-jumbo as as possible. bleeding-mask will use this new parameter to make mask mode code better. 
> 
> I have applied this patch to bleeding-mask. Please review this patch and add it to jumbo as well.

I think we should stop and think for a minute first. Why not just use a global variable instead? All formats initially set this to zero, even your mask-enabled ones - so what good does this in the format struct?

magnum


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.