Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <34bb681580d62abf69132581357f4487@smtp.hushmail.com>
Date: Fri, 12 Jul 2013 11:22:40 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: BUG in pbkdf2_hmac_sha1_unsplit_kernel.cl

On 12 Jul, 2013, at 8:01 , marcus.desto <marcus.desto@...pl> wrote:
> I suggest, you should introduce testing to your project, like unit testing, whitebox and blackbox testing.

We have built-in self-tests as well as the more extensive "Test Suite" (https://github.com/magnumripper/jtrTestSuite). But in this case no tests were using that long salts. Actually most (all?) formats using this shared code (eg. zip, dmg, strip, odf) has a fixed salt length of eg. 8 or 16 so I'm not sure this bug ever surfaced in our current formats.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.