Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ef285f6bbae3312f50bad3d5b11f9674@smtp.hushmail.com>
Date: Thu, 4 Jul 2013 20:41:12 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: bug: GPU use in CPU-only formats

On 4 Jul, 2013, at 17:51 , magnum <john.magnum@...hmail.com> wrote:
> On 3 Jul, 2013, at 13:31 , Claudio André <claudioandre.br@...il.com> wrote:
>>> For some reason, it didn't work but it's gotta be just a minor detail. The idea is that absolutely no OpenCL code is called until calling an opencl-format's init(). If we at that point find that the --device option is invalid, we'll bail out at that point. If that is after 10 seconds of loading millions of hashes, so be it.
>> 
>> How did it failed? I see no detail missing.
>> - GPU was still in use ?
>> - OpenCL formats did not work?
>> - Things worked, but with some strange error?
> 
> It works like expected with non-opencl formats (my laptop does not switch to discrete GPU). But opencl formats fail:
> 
> OpenCL error (CL_INVALID_CONTEXT) in file (common-opencl.c) at line (560) - (Error while creating program)
> 
>> Have you committed somewhere?
> 
> Committed now to temporary branch "opencl-init".

I'm starting to think we should drop that branch and try to straighten things out properly. Here's what I think we should do:

1. (This is a side track) Re-factor all non-static functions in common-opencl.c so they are prefixed with opencl_, eg:

init_opencl_devices() -> opencl_passive_init()
clean_opencl_environment() -> opencl_done()

2. Re-work opencl_passive_init() so it does the platform/device enumeration and option parsing but does *not* set up any queue or context (I am confident that's what wakes up the GTX 570).

3. Add such setting up of queue and context in opencl_init_opt().

And then we keep calling opencl_passive_init() from john.c but it won't wake up the nvidia. I'll think this over for a while.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.