[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+TsHUCac9MUomh84EyXpua4i9t9g3dr7NQcCBWEN_fXaqqNLA@mail.gmail.com>
Date: Wed, 29 May 2013 03:14:33 +0530
From: Sayantan Datta <std2048@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Unify internal form of mscash2 hashes?
On Tue, May 28, 2013 at 9:31 PM, Frank Dittrich
<frank_dittrich@...mail.com>wrote:
> On 05/28/2013 05:40 PM, magnum wrote:
> > On 28 May, 2013, at 10:18 , Sayantan Datta <std2048@...il.com> wrote:
> >> On Tue, May 28, 2013 at 12:51 PM, magnum <john.magnum@...hmail.com>
> wrote:
> >>> Sayantan, will you have a look at this please? I think you merely need
> to take prepare() as-is from the CPU format.
> >>
> >> Cool, no problem.
> >>
> >>> You can get rid of some whitespace noise while at it ;-)
> >>
> >> Do you mean unstable because I already did the cleanup in bleeding. I
> also got rid of many unnecessary global variables and used claudio's new
> interfaces more efficiently.
> >
> > Still trailing whitespace in a number of places. I don't care too much
> but git nags about it too anytime you touch the file without dropping them.
>
> You might want to experiment with a pre-commit hook that automatically
> removes trailing whitespace or spaces before tabs in a *non-public*
> repo, and if it turns out to work without unwanted side effects, enable
> that pre-comkmit hook in the public repo.
>
>
>
> http://stackoverflow.com/questions/591923/make-git-automatically-remove-trailing-whitespace-before-committing
>
> https://gist.github.com/nomadcoder/663933
>
>
> We might consider a separate whitespace-fix commit before bleeding
> becomes the next unstable (and/or for unstable before it is released as
> a next jumbo).
>
>
> This should be scheduled so that we don't have too many conflicting
> changes caused by people doing serious work instead of just "cosmetic"
> fixes.
>
>
> Frank
>
Works great but there is one problem. It can't remove trailing white spaces
from multiple files simultaneously.
Regards,
Sayantan
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
