[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANO7a6xG6w1hGv5_sDajCcuGr9KTwZxYm3d4Kcn=xGyDO7FiOg@mail.gmail.com>
Date: Sat, 18 May 2013 21:27:34 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: rules reading from user classes in john.conf. Avoids
multiple defined characters
On Sat, May 18, 2013 at 8:43 PM, <jfoug@....net> wrote:
> This patch will eliminated adding the same character more than one time. (This patch will NOT apply properly, until after the redo regen-lost-salts patch has been applied)
>
> If this user class line:
>
> [UserClasses]
> 3 = [A-z0-9m-q]
>
> or
>
> [Regen_Salts_UserClasses]
> 3 = [A-z0-9a-m]
>
> The a-m would be in there 2 times. With the patch, each of these would only be included 1 time. Yes, the above user class values are contrived, but an easy to make mistake. The z likely should have been Z. But a user causing overlap is often easy to do, and the patch avoids this by ignoring adding the character values a 2nd time.
Committed to bleeding-jumbo.
--
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
