[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8b13cad34b51218896906b428052f9d7@smtp.hushmail.com>
Date: Thu, 16 May 2013 20:33:41 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: missing parentheses in dynamic_fmt.c
On 16 May, 2013, at 20:03 , "jfoug" <jfoug@....net> wrote:
> The problem was a MD5-x2 bug. In the X2, there were 2 inputs getting 0x10
> bytes written to them. But one of them was not getting the length set.
That fixed dyna_1300 in my -generic build. However, we still have these:
dynamic_fmt.c: In function 'FreeBSDMD5Crypt_setup_nonMMX':
dynamic_fmt.c:4512:92: warning: assignment makes integer from pointer without a cast [enabled by default]
md5_items[14].off[i] = md5_items[15].off[i] = md5_items[18].off[i] = md5_items[20].off[i] = &cp1[cp-cp1];
^
dynamic_fmt.c:4553:46: warning: assignment makes integer from pointer without a cast [enabled by default]
md5_items[16].off[i] = md5_items[19].off[i] = &cp1[cp-cp1];
^
dynamic_fmt.c:4589:45: warning: assignment makes integer from pointer without a cast [enabled by default]
md5_items[3].off[i] = md5_items[17].off[i] = &cp1[cp-cp1];
^
dynamic_fmt.c:4622:23: warning: assignment makes integer from pointer without a cast [enabled by default]
md5_items[10].off[i] = &cp1[cp-cp1];
^
In file included from dynamic_big_crypt.c:58:0:
dynamic_types.h:317:16: warning: 'tmpOut' defined but not used [-Wunused-variable]
static MD5_OUT tmpOut;
^
The "integer from pointer" warnings often point to brutal bugs that segfaults, but in this case, all formats do pass self-test.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
