[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130511122929.7VAF4.2863.imail@eastrmwml214>
Date: Sat, 11 May 2013 12:29:29 -0400
From: <jfoug@....net>
To: john-dev@...ts.openwall.com
Cc: Alexander Cherepanov <cherepan@...me.ru>
Subject: Re: Unused global symbols in core
Patch 3 is the wrong way to go about this 'issue'. We should find out where there are local defined items, and instead use the global. It 'should' be global, and not a static.
Jim.
---- Alexander Cherepanov <cherepan@...me.ru> wrote:
> Hi, Solar!
>
> There are unused global symbols in JtR. Here is the analysis for the core:
>
> 1. Easy to fix:
> crk_remove_hash cracker.o <- cracker.c:135
>
> 2. Easy to fix:
> DES_KS_table DES_std.o
>
> 3. Not used but supposed to be used (described in .h)?
> itoa64 common.o <- common.c:11
>
> 4. Not used but supposed to be used (described in .h)?
> fmt_default_valid formats.o <- formats.c:257
> fmt_default_binary formats.o <- formats.c:267
>
> 5. The following are described in rules.h but should they really be
> exported?
> rules_errno rules.o
> rules_line rules.o
> rules_errors rules.o <- rules.c:20
> rules_check rules.o <- rules.c:959
>
> 6. Not used in JtR itself but used in best.c:
> benchmark_cps bench.o <- bench.c:211
> benchmark_format bench.o <- bench.c:87
>
> 7. Ok, the following should be non-static:-)
> main john.o <- john.c:649
>
> Attached are patches for the first 5 cases (selftests passed). First
> seems to be a sure target, but it's harder to tell for others -- maybe
> they are supposed to be that way.
>
> --
> Alexander Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
