[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130506004756.GB26797@openwall.com>
Date: Mon, 6 May 2013 04:47:56 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Core: build warning
On Sun, May 05, 2013 at 08:15:11PM +0200, magnum wrote:
> inc.c: In function ?do_incremental_crack?:
> inc.c:478: warning: comparison is always false due to limited range of data type
Yes, I had expected that we'd get this sort of warnings, and I was
surprised I was not getting any of them. I still don't know why not.
For me, gcc silently omits the "offending" check from generated code.
> Here's the "offending" code:
>
> if (header->count > CHARSET_SIZE)
> inc_format_error(charset);
>
> Well it's not really a bug... so maybe just wrap that in #if CHARSET_SIZE < 255 to avoid the warning?
I just did.
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
