[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130418203429.GA28788@openwall.com>
Date: Fri, 19 Apr 2013 00:34:29 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: [patch] sse/xop implementation of raw-sha512
magnum, all -
On Wed, Apr 17, 2013 at 08:54:15AM +0400, Solar Designer wrote:
> On Mon, Apr 15, 2013 at 01:53:32AM +0200, magnum wrote:
> > I added OMP support. Scales well on Intel, but worse on AMD:
>
> Thanks! I made some further optimizations, mostly trivial stuff. With
> this, the speed on FX-8120 with OpenMP is 11M c/s. Patch attached.
There was a big in that patch. This change:
> - while (buf8[len] && len <= MAXLEN)
> + while (buf8[len] && len < MAXLEN)
should be reverted/excluded. "len <= MAXLEN" is correct, because the
previous password might have been of MAXLEN chars and if the new one is
shorter, then we need to overwrite the 0x80 in buf8[MAXLEN] with 0.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
