[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130317223056.GA10803@openwall.com>
Date: Mon, 18 Mar 2013 02:30:56 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: All *2john programs should use basename of filename when put as ?login? field
Lukas -
On Sun, Mar 17, 2013 at 10:54:55PM +0100, Lukas Odzioba wrote:
> char *get_basename(const char *path, const char *extensions[], int count)
> {
> assert(path);
> assert(*path);
>
> static char retmem[64];
I did not seriously review this function, but you're mixing statements
and declarations here, which we had decided not to do in JtR yet (for
portability to older C compilers).
As to having a function like this in misc.c in jumbo, I'm fine with that.
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
