Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6666d1ae35b18a40236dd4d778ef91f5@smtp.hushmail.com>
Date: Tue, 15 Jan 2013 23:05:12 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: New compiler warnings (was: charset.c warnings)

On 15 Jan, 2013, at 22:29 , magnum <john.magnum@...hmail.com> wrote:
> Solar,
>  
> Frank pointed out that the following will mute the inline warnings:
> 
>  -#define MAYBE_INLINE attribute((always_inline))
>  +#define MAYBE_INLINE attribute((always_inline)) inline
> 
> Should we commit this? I don't really understand the difference.

I did so. Some googling reveals this is a better definition anyway, since at least some compilers will totally ignore that attribute without the inline specification added.

I also replaced a similar construct in dummy.c to MAYBE_INLINE, maybe you should in core too.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.